Re: [PATCH 03/10] ftrace: Add register_ftrace_direct()

From: Miroslav Benes
Date: Wed Nov 13 2019 - 09:13:49 EST



> @@ -1757,6 +1761,18 @@ static bool __ftrace_hash_rec_update(struct ftrace_ops *ops,
> return false;
> rec->flags--;
>
> + if (ops->flags & FTRACE_OPS_FL_DIRECT)
> + rec->flags &= ~FTRACE_FL_DIRECT;
> +
> + /*
> + * Only the internal direct_ops should have the
> + * DIRECT flag set. Thus, if it is removing a
> + * function, then that function should no longer
> + * be direct.
> + */
> + if (ops->flags & FTRACE_OPS_FL_DIRECT)
> + rec->flags &= ~FTRACE_FL_DIRECT;
> +

The flag is dropped twice here.

Miroslav