Re: [PATCH v5] ARM: dts: exynos5420: add mali dt node and enable mali on Odroid XU3/4

From: Krzysztof Kozlowski
Date: Thu Nov 14 2019 - 08:06:50 EST


On Thu, Nov 14, 2019 at 10:39:00AM +1030, Marian Mihailescu wrote:
> Add device tree node for Mali GPU for Exynos 542x SoC.
> GPU is disabled by default, and is enabled for each board after the
> regulator is defined. Tested on Odroid-XU4.
>
> Signed-off-by: Marian Mihailescu <mihailescu2m@xxxxxxxxx>
> ---
>
> Changes since v4:
> - fixed so it applies for latest 5.4-rc7
>
> Changes since v3:
> - fixed compatible to match bindings
>
> Changes since v2:
> - separate patch for bindings
> - fixed bindings typo
>
> Changes since v1:
> - used generic node and label for GPU
> - added bindings for compatible
> - fixed irq indentation
> - fixed interrupt-names to match bindings
> - added cooling cells for future TMU connection
> - used generic node and label for GPU opp table
> - removed always-on from SoC GPU regulator
>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 50 +++++++++++++++++++++++++++
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 +++-
> 2 files changed, 55 insertions(+), 1 deletion(-)

Again tried to apply... but it causes new DTS warnings:

arch/arm/boot/dts/exynos5420.dtsi:692.19-695.7: Warning (unit_address_vs_reg): /soc/gpu@11800000/opp-table/opp@177000000: node has a unit name, but no reg property

Send the patches passing checkpatch and not introducing warnings (make
dtbs W=1).

Best regards,
Krzysztof