Re: [PATCH v2 2/5] dt-bindings: serial: Convert sprd-uart to json-schema

From: Rob Herring
Date: Thu Nov 14 2019 - 15:52:39 EST


On Mon, Nov 11, 2019 at 05:02:27PM +0800, Chunyan Zhang wrote:
>
> Convert the sprd-uart binding to DT schema using json-schema.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
> ---
> .../devicetree/bindings/serial/sprd-uart.txt | 32 ---------
> .../devicetree/bindings/serial/sprd-uart.yaml | 69 +++++++++++++++++++
> 2 files changed, 69 insertions(+), 32 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/serial/sprd-uart.txt
> create mode 100644 Documentation/devicetree/bindings/serial/sprd-uart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> deleted file mode 100644
> index 9607dc616205..000000000000
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -* Spreadtrum serial UART
> -
> -Required properties:
> -- compatible: must be one of:
> - * "sprd,sc9836-uart"
> - * "sprd,sc9860-uart", "sprd,sc9836-uart"
> -
> -- reg: offset and length of the register set for the device
> -- interrupts: exactly one interrupt specifier
> -- clock-names: Should contain following entries:
> - "enable" for UART module enable clock,
> - "uart" for UART clock,
> - "source" for UART source (parent) clock.
> -- clocks: Should contain a clock specifier for each entry in clock-names.
> - UART clock and source clock are optional properties, but enable clock
> - is required.
> -
> -Optional properties:
> -- dma-names: Should contain "rx" for receive and "tx" for transmit channels.
> -- dmas: A list of dma specifiers, one for each entry in dma-names.
> -
> -Example:
> - uart0: serial@0 {
> - compatible = "sprd,sc9860-uart",
> - "sprd,sc9836-uart";
> - reg = <0x0 0x100>;
> - interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> - dma-names = "rx", "tx";
> - dmas = <&ap_dma 19>, <&ap_dma 20>;
> - clock-names = "enable", "uart", "source";
> - clocks = <&clk_ap_apb_gates 9>, <&clk_uart0>, <&ext_26m>;
> - };
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> new file mode 100644
> index 000000000000..0cc4668a9b9c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license please. If you are okay with that on both patches, I can
fix them and apply patches 1-4.

Rob