Re: [PATCH v5 3/7] scsi: ufs: Fix up auto hibern8 enablement

From: Stanley Chu
Date: Fri Nov 15 2019 - 08:46:52 EST


Hi Can,

On Fri, 2019-11-15 at 20:27 +0800, Can Guo wrote:

> Hi Stanley,
>
> Actually, I thought about the way you reommand.
>
> But I guess the author's intention here is to update the AH8 timer
> only when current runtime status is RPM_ACTIVE. If it is not RPM_ACTIVE,
> we just update the hba->ahit and bail out, because the AH8 timer will be
> updated in ufshcd_reusme() eventually when hba is resumed. This can
> avoid
> frequently waking up hba just for accessing a single register.
> How do you think?
>
> Thanks,
> Can Guo.
>
>

Agree with you.

Thanks :)

Reviewed-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>