Re: [PATCH] wil6210: fix break that is never reached because of zero'ing of a retry counter

From: merez
Date: Sun Nov 17 2019 - 03:10:24 EST


On 2019-11-15 14:09, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

There is a check on the retry counter invalid_buf_id_retry that is always
false because invalid_buf_id_retry is initialized to zero on each iteration
of a while-loop. Fix this by initializing the retry counter before the
while-loop starts.

Addresses-Coverity: ("Logically dead code")
Fixes: b4a967b7d0f5 ("wil6210: reset buff id in status message after
completion")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---

Note: not tested, so I'm not sure if the loop retry threshold is high enough

---

Reviewed-by: Maya Erez <merez@xxxxxxxxxxxxxx>