Re: [PATCH] rtc: msm6242: Fix reading of 10-hour digit

From: Geert Uytterhoeven
Date: Mon Nov 18 2019 - 09:15:01 EST

On Sat, Nov 16, 2019 at 12:06 PM Kars de Jong <jongk@xxxxxxxxxxxxxx> wrote:
> The driver was reading the wrong register as the 10-hour digit due to
> a misplaced ')'. It was in fact reading the 1-second digit register due
> to this bug.
> Also remove the use of a magic number for the hour mask and use the define
> for it which was already present.
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Tested-by: Kars de Jong <jongk@xxxxxxxxxxxxxx>
> Signed-off-by: Kars de Jong <jongk@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds