Re: [PATCH] rtc: msm6242: Fix reading of 10-hour digit

From: Alexandre Belloni
Date: Mon Nov 18 2019 - 09:18:59 EST


On 16/11/2019 12:05:48+0100, Kars de Jong wrote:
> The driver was reading the wrong register as the 10-hour digit due to
> a misplaced ')'. It was in fact reading the 1-second digit register due
> to this bug.
>
> Also remove the use of a magic number for the hour mask and use the define
> for it which was already present.
>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Tested-by: Kars de Jong <jongk@xxxxxxxxxxxxxx>
> Signed-off-by: Kars de Jong <jongk@xxxxxxxxxxxxxx>
> ---
> drivers/rtc/rtc-msm6242.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com