Re: [PATCH] perf/x86/uncore: Remove unnecessary check for uncore_pmu
From: Pavel Machek
Date: Mon Nov 18 2019 - 09:36:40 EST
On Wed 2019-11-13 05:35:02, kan.liang@xxxxxxxxxxxxxxx wrote:
> From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> The uncore_pmu pointer in uncore_pmu_enable/disable() is from
> container_of, which never be NULL.
> Remove the unnecessary check for uncore_pmu.
> Fixes: 75be6f703a14 ("perf/x86/uncore: Fix event group support")
> Reported-by: Pavel Machek <pavel@xxxxxxx>
> Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
Sorry, sent email too fast.
I agree this is good fix for mainline, but as the code is a tiny bit
ineffective but correct, I don't think we neccessarily need it in
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Description: PGP signature