Re: [PATCH v3 1/2] dt-bindings: interconnect: Add OSM L3 DT bindings

[sibis]

Hey Stephen,

Thanks for taking time to
review the series.

On 2019-11-19 06:01, Stephen Boyd wrote:
> Quoting Sibi Sankar (2019-11-18 07:45:21)
> > diff --git 
> > a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml 
> > b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> > new file mode 100644
> > index 0000000000000..fec8289ceeeed
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> > @@ -0,0 +1,56 @@
> > +examples:
> > +  - |
> > +    osm_l3: interconnect@17d41000 {
> > +      compatible = "qcom,sdm845-osm-l3";
> > +      reg = <0x17d41000 0x1400>;
> > +
> > +      clocks = <&rpmhcc 0>, <&gcc 165>;
>
> Can you use #define names here? That would make it clearer what sort of
> clk is expected here.

yes will do that.

> > +      clock-names = "xo", "alternate";
> > +
> > +      #interconnect-cells = <1>;
> > +    };