Re: [PATCH v4 linux-kselftest-test 1/6] kunit: move string-stream.h to lib/kunit

From: Brendan Higgins
Date: Tue Nov 19 2019 - 13:40:08 EST


On Fri, Nov 15, 2019 at 2:17 AM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote:
>
> string-stream interfaces are not intended for external use;
> move them from include/kunit to lib/kunit accordingly.
>
> Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
> Signed-off-by: Knut Omang <knut.omang@xxxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
Tested-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Stephen pointed out a couple of nits, but beyond that this looks good to me.

Thanks for all your hard work!