Re: [PATCH v4 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h

From: Brendan Higgins
Date: Tue Nov 19 2019 - 13:48:17 EST


On Fri, Nov 15, 2019 at 2:17 AM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote:
>
> Define function as static inline in try-catch-impl.h to allow it to
> be used in kunit itself and tests. Also remove unused
> kunit_generic_try_catch
>
> Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
Tested-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Aside from Stephen's comment, this looks good to me.