Re: [PATCH 2/2] MAINTAINERS: Switch to Marvell addresses

From: Joe Perches
Date: Tue Nov 19 2019 - 16:12:27 EST

On Tue, 2019-11-19 at 20:23 +0000, Robert Richter wrote:
> Joe,
> thanks for your review.
> On 19.11.19 11:56:53, Joe Perches wrote:
> > Maybe make that change globally in all the files other
> > than MAINTAINERS as well eventually.
> >
> > arch/arm64/mm/numa.c:6: * Author: Ganapatrao Kulkarni <gkulkarni@xxxxxxxxxx>
> > arch/mips/cavium-octeon/octeon-usb.c:551:MODULE_AUTHOR("David Daney <david.daney@xxxxxxxxxx>");
> > arch/mips/include/asm/octeon/cvmx-coremask.h:6: * Copyright (c) 2016 Cavium Inc. (support@xxxxxxxxxx).
> [...]
> This is a bit past the scope of this patch.

Yup, completely agree, as it seems I understated with "eventually".

> I will leave that change to the driver's maintainers.

Fine by me. btw: There's also entries for
so those might change one day too.

> I also think that authorship does not
> change even if the author's email address changed or vanished later. I
> am not sure on the general handling of MODULE_AUTHOR(), should that
> always contain a valid email address? Seems not the case. I don't
> think somebody actually sends an email to the author, it is more to
> better identify the author.

Changelog identifies the author, MODULE_AUTHOR is actually
available via modinfo -a, which shows email if entered,
but that may also be rarely used in practice.