Re: [PATCH 2/4] coccinelle: platform_get_irq: handle 2-statement branches

From: Markus Elfring
Date: Tue Nov 19 2019 - 16:33:52 EST


> From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

I wonder about this information.
Would you like to use the tag âSuggested-byâ instead?


â
> +++ b/scripts/coccinelle/api/platform_get_irq.cocci
> @@ -31,6 +31,25 @@ if ( \( ret < 0 \| ret <= 0 \) )
â
> +ret =
> +(
> +platform_get_irq
> +|
> +platform_get_irq_byname
> +)(E, ...);
> +
> +if ( \( ret < 0 \| ret <= 0 \) )
> +-{
> +-dev_err(...);
> +S
> +-}

How do you think about to use the following SmPL code variant?

+ ret =
+(platform_get_irq
+|platform_get_irq_byname
+)(E, ...);
+
+ if ( \( ret < 0 \| ret <= 0 \) )
+-{
+-dev_err(...);
+ S
+-}

Regards,
Markus