Re: [PATCH] padata: Remove broken queue flushing
From: Herbert Xu
Date: Tue Nov 19 2019 - 16:53:54 EST
On Tue, Nov 19, 2019 at 02:24:05PM -0500, Daniel Jordan wrote:
> __padata_free unconditionally frees pd, so a padata job might choke on it
> later. padata_do_parallel calls seem safe because they use RCU, but it seems
> possible that a job could call padata_do_serial after the instance is gone.
Actually __padata_free no longer frees the pd after my patch.
We should also mandate that __padata_free can only be called after
all jobs have completed. This is already the case with pcrypt.
In fact we should discuss merging padata into pcrypt. It's been
10 years and not a single user of padata has emerged in the kernel.
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt