Re: [PATCH] fork: fix pidfd_poll()'s return type
From: Christian Brauner
Date: Tue Nov 19 2019 - 19:21:51 EST
On Wed, Nov 20, 2019 at 01:07:22AM +0100, Luc Van Oostenryck wrote:
> pidfd_poll() is defined as returning 'unsigned int' but the
> .poll method is declared as returning '__poll_t', a bitwise type.
> Fix this by using the proper return type and using the EPOLL
> constants instead of the POLL ones, as required for __poll_t.
> CC: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>
> CC: Christian Brauner <christian@xxxxxxxxxx>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
Yeah, that makes sense. Thanks.
This only misses two tags:
Fixes: b53b0b9d9a61 ("pidfd: add polling support")
Cc: stable@xxxxxxxxxxxxxxx # 5.3
Can you add these two tags to the commit message for v1 and resend with
stable@xxxxxxxxxxxxxxx Cced, please?
Reviewed-by: Christian Brauner <christian.brauner@xxxxxxxxxx>