Re: [PATCH v9 03/22] RISC-V: Add initial skeletal KVM support

From: Paul Walmsley
Date: Wed Nov 20 2019 - 03:04:17 EST


Hi,

On Wed, 16 Oct 2019, Anup Patel wrote:

> This patch adds initial skeletal KVM RISC-V support which has:
> 1. A simple implementation of arch specific VM functions
> except kvm_vm_ioctl_get_dirty_log() which will implemeted
> in-future as part of stage2 page loging.
> 2. Stubs of required arch specific VCPU functions except
> kvm_arch_vcpu_ioctl_run() which is semi-complete and
> extended by subsequent patches.
> 3. Stubs for required arch specific stage2 MMU functions.
>
> Signed-off-by: Anup Patel <anup.patel@xxxxxxx>
> Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Reviewed-by: Alexander Graf <graf@xxxxxxxxxx>

Olof's autobuilder found an issue with this patch (below)

> diff --git a/arch/riscv/include/asm/kvm_host.h b/arch/riscv/include/asm/kvm_host.h
> new file mode 100644
> index 000000000000..9459709656be
> --- /dev/null
> +++ b/arch/riscv/include/asm/kvm_host.h
> @@ -0,0 +1,81 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

This should be

/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */

to match the license used in the kvm.h files in other architectures.


- Paul