Re: [PATCH v3 2/4] x86/traps: Print non-canonical address on #GP

From: Jann Horn
Date: Wed Nov 20 2019 - 07:25:59 EST


On Wed, Nov 20, 2019 at 12:24 PM Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Wed, Nov 20, 2019 at 12:18:59PM +0100, Ingo Molnar wrote:
> > How was this maximum string length of '90' derived? In what way will
> > that have to change if someone changes the message?
>
> That was me counting the string length in a dirty patch in a previous
> thread. We probably should say why we decided for a certain length and
> maybe have a define for it.

Do you think something like this would be better?

char desc[sizeof(GPFSTR) + 50 + 2*sizeof(unsigned long) + 1] = GPFSTR;