Re: [PATCH] block,bfq: Skip tracing hooks if possible

From: Jens Axboe
Date: Wed Nov 20 2019 - 20:59:32 EST


On 11/1/19 7:11 AM, Dmitry Monakhov wrote:
> In most cases blk_tracing is not active, but bfq_log_bfqq macro
> generate pid_str unconditionally, which result in significant overhead.
>
> ## Test
> modprobe null_blk
> echo bfq > /sys/block/nullb0/queue/scheduler
> fio --name=t --ioengine=libaio --direct=1 --filename=/dev/nullb0 \
> --runtime=30 --time_based=1 --rw=write --iodepth=128 --bs=4k
>
> # Results
> | | baseline | w/ patch | gain |
> | iops | 113.19K | 126.42K | +11% |

Applied, thanks.

--
Jens Axboe