Re: [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.

From: Jiaxun Yang
Date: Thu Nov 21 2019 - 01:12:56 EST




ä 2019å11æ21æ GMT+08:00 äå9:41:56, Lichao Liu <liulichao@xxxxxxxxxxx> åå:
>Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
>to control whether to include the asm/i8259.h header file.
>
>Signed-off-by: Lichao Liu <liulichao@xxxxxxxxxxx>

Acked-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>

I'm glad to see Loongson guys finally get here.

I will send v3 of my previous "modernize" set.
Which will also refactor interrupt part.
Do you have any comments based on v2 [1]?

[1]: https://patchwork.kernel.org/cover/11133237/
>---
> arch/mips/loongson64/common/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/mips/loongson64/common/pm.c
>b/arch/mips/loongson64/common/pm.c
>index b8aed878d..bc619e4d0 100644
>--- a/arch/mips/loongson64/common/pm.c
>+++ b/arch/mips/loongson64/common/pm.c
>@@ -9,7 +9,9 @@
> #include <linux/interrupt.h>
> #include <linux/pm.h>
>
>+#ifdef CONFIG_I8259
> #include <asm/i8259.h>
>+#endif
> #include <asm/mipsregs.h>
>
> #include <loongson.h>

--
Jiaxun Yang