Re: [PATCH v4 03/13] exfat: add inode operations

From: Markus Elfring
Date: Thu Nov 21 2019 - 05:42:16 EST


â
> +++ b/fs/exfat/inode.c
â
> +static int exfat_bmap(struct inode *inode, sector_t sector, sector_t *phys,
> + unsigned long *mapped_blocks, int *create)
> +{
â
> + err = exfat_map_cluster(inode, clu_offset, &cluster,
> + *create & BMAP_ADD_CLUSTER);

I find an other indentation more appropriate.
Please align the last parameter below (or besides) the opening parenthesis.


> + if (err) {
> + if (err != -ENOSPC)
> + return -EIO;
> + return err;
> + }

Can such source code become more succinct?

+ if (err)
+ return err != -ENOSPC ? -EIO : err;

Regards,
Markus