Re: [PATCH 3/3] sched/fair: Consider uclamp for "task fits capacity" checks

From: Quentin Perret
Date: Thu Nov 21 2019 - 06:56:10 EST


On Wednesday 20 Nov 2019 at 17:55:33 (+0000), Valentin Schneider wrote:
> +static inline
> +unsigned long uclamp_task_util(struct task_struct *p, unsigned long util)

This 'util' parameter is always task_util_est(p) right ? You might want
to remove it.

> +{
> + return clamp(util,
> + (unsigned long)uclamp_eff_value(p, UCLAMP_MIN),
> + (unsigned long)uclamp_eff_value(p, UCLAMP_MAX));
> +}

Thanks,
Quentin