Re: [PATCH] of: property: Fix the semantics of of_is_ancestor_of()
From: Greg Kroah-Hartman
Date: Thu Nov 21 2019 - 07:00:52 EST
On Wed, Nov 20, 2019 at 01:50:42PM -0800, Saravana Kannan wrote:
> On Wed, Nov 20, 2019 at 7:36 AM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Wed, Nov 20, 2019 at 12:02:29AM -0800, Saravana Kannan wrote:
> > > The of_is_ancestor_of() function was renamed from of_link_is_valid()
> > > based on review feedback. The rename meant the semantics of the function
> > > had to be inverted, but this was missed in the earlier patch.
> > >
> > > So, fix the semantics of of_is_ancestor_of() and invert the conditional
> > > expressions where it is used.
> > >
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> > > ---
> > > drivers/of/property.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > What git commit does this patch fix?
> Fixes commit a3e1d1a7f5fcc. Let me know if you want me to send a v2 or
> if you can fix up the commit text on your end.
I'll fix it up.