Re: [PATCH 10/12] crypto: caam - add crypto_engine support for AEAD algorithms

[Horia Geanta]

On 11/18/2019 12:31 AM, Iuliana Prodan wrote:
> @@ -1465,7 +1484,6 @@ static inline int aead_crypt(struct aead_request *req, bool encrypt)
>  	struct aead_edesc *edesc;
>  	struct crypto_aead *aead = crypto_aead_reqtfm(req);
>  	struct caam_ctx *ctx = crypto_aead_ctx(aead);
> -	struct caam_jr_request_entry *jrentry;
>  	struct device *jrdev = ctx->jrdev;
>  	bool all_contig;
>  	u32 *desc;
> @@ -1479,16 +1497,14 @@ static inline int aead_crypt(struct aead_request *req, bool encrypt)
>  
>  	/* Create and submit job descriptor */
>  	init_authenc_job(req, edesc, all_contig, encrypt);
> +	desc = edesc->hw_desc;
>  
This change is unrelated.

>  	print_hex_dump_debug("aead jobdesc@"__stringify(__LINE__)": ",
> -			     DUMP_PREFIX_ADDRESS, 16, 4, edesc->hw_desc,
> -			     desc_bytes(edesc->hw_desc), 1);
> -
> -	desc = edesc->hw_desc;
> -	jrentry = &edesc->jrentry;
> +			     DUMP_PREFIX_ADDRESS, 16, 4, desc,
> +			     desc_bytes(desc), 1);
>  
[...]
>  static inline int gcm_crypt(struct aead_request *req, bool encrypt)
>  {
>  	struct aead_edesc *edesc;
>  	struct crypto_aead *aead = crypto_aead_reqtfm(req);
>  	struct caam_ctx *ctx = crypto_aead_ctx(aead);
>  	struct device *jrdev = ctx->jrdev;
> -	struct caam_jr_request_entry *jrentry;
>  	bool all_contig;
>  	u32 *desc;
>  	int ret = 0;
> @@ -1525,16 +1565,14 @@ static inline int gcm_crypt(struct aead_request *req, bool encrypt)
>  
>  	/* Create and submit job descriptor */
>  	init_gcm_job(req, edesc, all_contig, encrypt);
> +	desc = edesc->hw_desc;
>  
Same here.

>  	print_hex_dump_debug("aead jobdesc@"__stringify(__LINE__)": ",
> -			     DUMP_PREFIX_ADDRESS, 16, 4, edesc->hw_desc,
> -			     desc_bytes(edesc->hw_desc), 1);
> -
> -	desc = edesc->hw_desc;
> -	jrentry = &edesc->jrentry;
> +			     DUMP_PREFIX_ADDRESS, 16, 4, desc,
> +			     desc_bytes(desc), 1);
>  

Horia