Re: [PATCH v8 2/2] dt-bindings: pinctrl: intel: Add for new SoC

From: Tanwar, Rahul
Date: Thu Nov 21 2019 - 21:53:21 EST




On 22/11/2019 10:24 AM, Tanwar, Rahul wrote:
> Hi Linus,
>
> On 21/11/2019 9:53 PM, Linus Walleij wrote:
>> On Fri, Nov 15, 2019 at 10:25 AM Rahul Tanwar
>> <rahul.tanwar@xxxxxxxxxxxxxxx> wrote:
>>
>>> Add dt bindings document for pinmux & GPIO controller driver of
>>> Intel Lightning Mountain SoC.
>>>
>>> Signed-off-by: Rahul Tanwar <rahul.tanwar@xxxxxxxxxxxxxxx>
>> Patch applied, you worked hard to get these bindings done in the
>> right YAML format and all.
>>
>> I have some generic bindings from Rob merged simultaneously
>> so it'd be great if you could investigate whether it is possible
>> to follow up with a patch to switch over from some of the local
>> grammar and toward including pinmux-node.yaml and
>> pincfg-node.yaml into these bindings.
>>
>> The method for inclusion of external generic files can be seen
>> in e.g. the display panel bindings, like how
>> panel-common.yaml is included into other bindings under
>> display/panel/*.yaml.
>>
>> Tell us if you have any problems with this!
> Thanks. Yes, i have gone through Rob's generic pinctrl bindings patch
> series and i was double minded if *i should still proceed with this
> patch or wait for generic bindings patch to get merged.
>
> I will take it up to revise this patch to include external generic
> files from Rob as soon as kernel 5.5 is released.

*Fix typo above.

> Regards,
> Rahul