RE: [PATCH v4 04/13] exfat: add directory operations

From: Namjae Jeon
Date: Fri Nov 22 2019 - 03:21:41 EST



> >> â
> >>> +++ b/fs/exfat/dir.c
> >> â
> >>> +static int exfat_readdir(struct inode *inode, struct exfat_dir_entry
> >> *dir_entry)
> >>> +{
> >> â
> >>> + if (!ep) {
> >>> + ret = -EIO;
> >>> + goto free_clu;
> >>> + }
> >>
> >> How do you think about to move a bit of common exception handling code
> >> (at similar places)?
> > Not sure it is good.
>
> The software development opinions can vary also for this change pattern
> according to different design goals.
> Is such a transformation just another possibility to reduce duplicate
> source code a bit?
I changed it without unnecessary goto abuse. Look at the next version later.
Thanks!
>
> Regards,
> Markus