Re: [Linux-stm32] [PATCH v2 1/1] drivers: watchdog: stm32_iwdg: set WDOG_HW_RUNNING at probe
From: Ahmad Fatoum
Date: Fri Nov 22 2019 - 08:31:31 EST
On 11/22/19 2:15 PM, Christophe ROULLIER wrote:
>> On 11/22/19 9:24 AM, Christophe Roullier wrote:
>>> + /*
>>> + * In case of CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED is set
>>> + * (Means U-Boot/bootloaders leaves the watchdog running)
>>> + * When we get here we should make a decision to prevent
>>> + * any side effects before user space daemon will take care of it.
>>> + * The best option, taking into consideration that there is no
>>> + * way to read values back from hardware, is to enforce watchdog
>>> + * being run with deterministic values.
>> What about the "ONF: Watchdog enable status bit" in the IWDG_SR register?
> Thanks Ahmad for your feedback, it is a mistake in our ref manual. This
> bit is not present
> in our iwdg IP, we will update our documentation accordingly.
Thanks for the info. I think it would be nice to have this information in
the driver as well, something like:
* The best option, taking into consideration that that the ONF
* watchdog status bit is non-functional, is to enforce watchdog
* being run with deterministic values.
This way it's clear that it's a deliberate choice to do it this way.
Pengutronix e.K. | |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |