Re: [PATCH] xhci: Increase STS_HALT timeout in xhci_suspend()

[Mathias Nyman]

On 22.11.2019 18.36, Kai-Heng Feng wrote:
> Hi Matthias,
>
> > On Nov 4, 2019, at 13:52, Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote:
> >
> > I've recently observed failed xHCI suspend attempt on AMD Raven Ridge
> > system:
> > kernel: xhci_hcd 0000:04:00.4: WARN: xHC CMD_RUN timeout
> > kernel: PM: suspend_common(): xhci_pci_suspend+0x0/0xd0 returns -110
> > kernel: PM: pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -110
> > kernel: PM: dpm_run_callback(): pci_pm_suspend+0x0/0x150 returns -110
> > kernel: PM: Device 0000:04:00.4 failed to suspend async: error -110
> >
> > Similar to commit ac343366846a ("xhci: Increase STS_SAVE timeout in
> > xhci_suspend()") we also need to increase the HALT timeout to make it be
> > able to suspend again.
>
> Seems like there are more broken AMD xHCI in the wild, so please merge this patch if there's no further concerns.
>
> Kai-Heng

Added to queue,

-Mathias