[PATCH 1/1] block/drbd/drbd_debugfs.c: Protect &connection->kref with resource->req_lock

From: kc27041980
Date: Mon Nov 25 2019 - 23:35:02 EST


From: KC27041980 <kc27041980@xxxxxxxxx>

Protect &connection->kref by moving it under resource->req_lock.

Signed-off-by: KC27041980 <kc27041980@xxxxxxxxx>
---
drivers/block/drbd/drbd_debugfs.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_debugfs.c b/drivers/block/drbd/drbd_debugfs.c
index b3b9cd5..f6d75fa 100644
--- a/drivers/block/drbd/drbd_debugfs.c
+++ b/drivers/block/drbd/drbd_debugfs.c
@@ -363,11 +363,15 @@ static int in_flight_summary_show(struct seq_file *m, void *pos)
struct drbd_connection *connection;
unsigned long jif = jiffies;

+ spin_lock_irq(&resource->req_lock);
connection = first_connection(resource);
/* This does not happen, actually.
* But be robust and prepare for future code changes. */
- if (!connection || !kref_get_unless_zero(&connection->kref))
+ if (!connection || !kref_get_unless_zero(&connection->kref)) {
+ spin_unlock_irq(&resource->req_lock);
return -ESTALE;
+ }
+ spin_unlock_irq(&resource->req_lock);

/* BUMP me if you change the file format/content/presentation */
seq_printf(m, "v: %u\n\n", 0);
--
2.7.4