Re: [RFC PATCH 3/3] gfs2: Rework read and page fault locking

From: Andreas GrÃnbacher
Date: Tue Nov 26 2019 - 04:08:27 EST


Am Mo., 25. Nov. 2019 um 10:16 Uhr schrieb Kirill A. Shutemov
<kirill@xxxxxxxxxxxxx>:
> On Sat, Nov 23, 2019 at 12:53:24AM +0100, Andreas Gruenbacher wrote:
> > @@ -778,15 +804,51 @@ static ssize_t gfs2_file_direct_write(struct kiocb *iocb, struct iov_iter *from)
> >
> > static ssize_t gfs2_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
> > {
> > + struct gfs2_inode *ip;
> > + struct gfs2_holder gh;
> > + size_t written = 0;
>
> 'written' in a read routine?

It's a bit weird, but it's the same as in generic_file_buffered_read.

> --
> Kirill A. Shutemov

Thanks,
Andreas