Re: linux-next: Tree for Nov 27 (drivers/pci/controller/dwc/pcie-designware-host.c)

[Dilip Kota]

On 11/28/2019 12:26 AM, Lorenzo Pieralisi wrote:
> On Wed, Nov 27, 2019 at 07:55:57AM -0800, Randy Dunlap wrote:
> > On 11/26/19 8:57 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Please do not add any material for v5.6 to your linux-next included
> > > trees until after v5.5-rc1 has been released.
> > >
> > > Changes since 20191126:
> > on i386:
> > # CONFIG_PCI_MSI is not set
> >
> >
> > WARNING: unmet direct dependencies detected for PCIE_DW_HOST
> >    Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> >    Selected by [y]:
> >    - PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])
> >
> > and related build errors:
> Dilip,
>
> I will have to drop your series which unfortunately forces Bjorn to pull
> my pci/dwc branch again, I don't think there is time for fixing it,
> given release timing and Stephen's request above.
My bad. I should have taken care of this.
Sorry for breaking it. I will submit a patch by marking PCI_INTEL_GW 
'depends on PCI_MSI_IRQ_DOMAIN'

Regards,
Dilip
> Lorenzo
>
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:72:15: error: variable âdw_pcie_msi_domain_infoâ has initializer but incomplete type
> >   static struct msi_domain_info dw_pcie_msi_domain_info = {
> >                 ^~~~~~~~~~~~~~~
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:73:3: error: âstruct msi_domain_infoâ has no member named âflagsâ
> >    .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
> >     ^~~~~
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:73:12: error: âMSI_FLAG_USE_DEF_DOM_OPSâ undeclared here (not in a function); did you mean âSIMPLE_DEV_PM_OPSâ?
> >    .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
> >              ^~~~~~~~~~~~~~~~~~~~~~~~
> >              SIMPLE_DEV_PM_OPS
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:73:39: error: âMSI_FLAG_USE_DEF_CHIP_OPSâ undeclared here (not in a function); did you mean âMSI_FLAG_USE_DEF_DOM_OPSâ?
> >    .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
> >                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
> >                                         MSI_FLAG_USE_DEF_DOM_OPS
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:74:6: error: âMSI_FLAG_PCI_MSIXâ undeclared here (not in a function); did you mean âSS_FLAG_BITSâ?
> >        MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI),
> >        ^~~~~~~~~~~~~~~~~
> >        SS_FLAG_BITS
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:74:26: error: âMSI_FLAG_MULTI_PCI_MSIâ undeclared here (not in a function); did you mean âMSI_FLAG_PCI_MSIXâ?
> >        MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI),
> >                            ^~~~~~~~~~~~~~~~~~~~~~
> >                            MSI_FLAG_PCI_MSIX
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:73:11: warning: excess elements in struct initializer
> >    .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
> >             ^
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:73:11: note: (near initialization for âdw_pcie_msi_domain_infoâ)
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:75:3: error: âstruct msi_domain_infoâ has no member named âchipâ
> >    .chip = &dw_pcie_msi_irq_chip,
> >     ^~~~
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:75:10: warning: excess elements in struct initializer
> >    .chip = &dw_pcie_msi_irq_chip,
> >            ^
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:75:10: note: (near initialization for âdw_pcie_msi_domain_infoâ)
> > ../drivers/pci/controller/dwc/pcie-designware-host.c: In function âdw_pcie_allocate_domainsâ:
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:267:19: error: implicit declaration of function âpci_msi_create_irq_domainâ; did you mean âpci_msi_get_device_domainâ? [-Werror=implicit-function-declaration]
> >    pp->msi_domain = pci_msi_create_irq_domain(fwnode,
> >                     ^~~~~~~~~~~~~~~~~~~~~~~~~
> >                     pci_msi_get_device_domain
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:267:17: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >    pp->msi_domain = pci_msi_create_irq_domain(fwnode,
> >                   ^
> > ../drivers/pci/controller/dwc/pcie-designware-host.c: At top level:
> > ../drivers/pci/controller/dwc/pcie-designware-host.c:72:31: error: storage size of âdw_pcie_msi_domain_infoâ isnât known
> >   static struct msi_domain_info dw_pcie_msi_domain_info = {
> >                                 ^~~~~~~~~~~~~~~~~~~~~~~
> >
> >
> > --
> > ~Randy
> > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>