Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn

From: Michal Hocko
Date: Thu Nov 28 2019 - 10:46:44 EST


On Thu 28-11-19 10:29:24, Qian Cai wrote:
> What I donât understand is that we have an policy prohibiting code
> churn like code optimization in cold path, but allow those micro
> cleanup of code. Those cleanup also tend to be unregulated and is
> subject to personal tastes (for example, your CS teachers may have a
> different taste from mine).

I tend to push back on cleanups without a clear added value. In this
particular case it is not about aesthetic or a personal feeling about
the code though. Please read my comment with the ack.

--
Michal Hocko
SUSE Labs