Re: dma-mapping: use bit macros

From: Christoph Hellwig
Date: Sat Nov 30 2019 - 03:19:20 EST

Next message: Paolo Bonzini: "Re: [PATCH RFC 00/15] KVM: Dirty ring interface"
Previous message: David Hildenbrand: "Re: [PATCH v4] mm: get rid of odd jump labels in find_mergeable_anon_vma()"
In reply to: Heiner Kallweit: "dma-mapping: use bit macros"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, Nov 29, 2019 at 09:27:26PM +0100, Heiner Kallweit wrote:
> Not necessarily a big leap for mankind, but using bit macros makes
> the code better readable, especially the definition of DMA_BIT_MASK
> is more intuitive.

NAK, I'm against this pointless obsfucation.

Next message: Paolo Bonzini: "Re: [PATCH RFC 00/15] KVM: Dirty ring interface"
Previous message: David Hildenbrand: "Re: [PATCH v4] mm: get rid of odd jump labels in find_mergeable_anon_vma()"
In reply to: Heiner Kallweit: "dma-mapping: use bit macros"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]