Re: [PATCH v2 1/2] gpio: mvebu: use platform_irq_count

From: Uwe Kleine-König
Date: Wed Dec 04 2019 - 13:48:08 EST


On Wed, Dec 04, 2019 at 05:33:04PM +0100, Bartosz Golaszewski wrote:
> År., 4 gru 2019 o 08:24 Uwe Kleine-KÃnig
> <u.kleine-koenig@xxxxxxxxxxxxxx> napisaÅ(a):
> >
> > On Wed, Dec 04, 2019 at 04:20:41AM +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > platform_irq_count() is the more generic way (independent of
> > > device trees) to determine the count of available interrupts. So
> > > use this instead.
> > >
> > > As platform_irq_count() might return an error code (which
> > > of_irq_count doesn't) some additional handling is necessary.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > Reviewed-and-Commit-Log-Provided-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> This is not a valid tag, but I take it as Suggested-by and Reviewed-by. :)

If you care about the validity of such tags, I suggest you take a look
at the output of

$ git rev-list v4.0..v5.4 | while read rev; do git cat-file commit $rev; done | sed -n 's/ *\(.*-by\):.*/\1/p' | sort | uniq -c | sort -n

(which finds all tags used between 4.0 and 5.4 with its usage count).

A few of the tags (admittedly with low usage count :-) included there are:

Badly-reviewed-by
Bonus-points-awarded-by
Compile-tested and Reviewed-by
Enthusiastically-Acked-by
Mea-culpa-by
\o/-by
Brown-paper-bag-by

Best regards
Uwe


--
Pengutronix e.K. | Uwe Kleine-KÃnig |
Industrial Linux Solutions | https://www.pengutronix.de/ |