Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node

From: Qian Cai
Date: Thu Dec 05 2019 - 14:34:30 EST




> On Dec 5, 2019, at 2:27 PM, Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx> wrote:
>
> John noticed another return value inconsistency between the implementation and the manpage. The manpage says it should return -ENOENT if the page is already on the target node, but it doesn't. It looks the original code didn't return -ENOENT either, I'm not sure if this is a document issue or not. Anyway this is another issue, once we confirm it we can fix it later.

No, I think it is important to figure out this in the first place. Otherwise, it is pointless to touch this piece of code over and over again, i.e., this is not another issue but the core of this problem on hand.