Re: [PATCH net v2] net: thunderx: start phy before starting autonegotiation

From: David Miller
Date: Thu Dec 05 2019 - 15:11:12 EST


From: Mian Yousaf Kaukab <ykaukab@xxxxxxx>
Date: Thu, 5 Dec 2019 10:41:16 +0100

> Since commit 2b3e88ea6528 ("net: phy: improve phy state checking")
> phy_start_aneg() expects phy state to be >= PHY_UP. Call phy_start()
> before calling phy_start_aneg() during probe so that autonegotiation
> is initiated.
>
> As phy_start() takes care of calling phy_start_aneg(), drop the explicit
> call to phy_start_aneg().
>
> Network fails without this patch on Octeon TX.
>
> Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@xxxxxxx>

Applied and queued up for -stable, thanks.