Re: media: go7007: fix a miss of snd_card_free

From: Markus Elfring
Date: Fri Dec 06 2019 - 12:01:01 EST


> I think using goto is really much better than freeing after every error.

Thanks for your positive feedback.


> I will send a new version if others also agree with this pattern.

* The error handling pattern would be supported by the Linux coding style.
The agreement on corresponding changes can occasionally become more challenging.

* I would interpret Dan Carpenter's review comment (from 2017-09-19) in the way
that he should be mentioned by the tag âReported-byâ in a subsequent patch.
https://lkml.org/lkml/2017/9/19/115

Regards,
Markus