Re: [PATCH v5 02/13] exfat: add super block operations

From: Namjae Jeon
Date: Fri Dec 06 2019 - 16:55:28 EST


>> +{
>> + struct exfat_sb_info *sbi = sb->s_fs_info;
>> + struct exfat_mount_options *opts = &sbi->options;
>> + struct inode *root_inode;
>> + int err;
>> +
>> + if (opts->allow_utime == -1)
>> + opts->allow_utime = ~opts->fs_dmask & 0022;
>
> This throws a warning when building with W=1:
>
> CC [M] fs/exfat/super.o
> fs/exfat/super.c: In function 'exfat_fill_super':
> fs/exfat/super.c:552:24: warning: comparison is always false due to limited
> range of data type [-Wtype-limits]
> 552 | if (opts->allow_utime == -1)
> | ^~
Okay, I will fix it on next version.
Thanks for review!