Re: [PATCH 0/4] mmc: simplify WP/CD GPIO handling

From: Linus Walleij
Date: Tue Dec 10 2019 - 19:37:19 EST


On Mon, Dec 9, 2019 at 10:09 PM MichaÅ MirosÅaw <mirq-linux@xxxxxxxxxxxx> wrote:

> This series removes convoluted handling of inverted CD and WP lines in
> SD/MMC host drivers when using GPIOs.
>
> First patch, sent separately earlier, adds gpiod_toggle_active_low() to
> switch line inversion flag in the gpiod structure. Next two patches
> modify WP and CD initialization to apply all the inversions onto gpiod's
> active-low flag. Final patch removes now-unused argument from init functions.

I like the approach, as much as I liked my own idea to centralize
all DT quirks and hide them in gpiolib-of.c I can see how this
makes it easier to solve the final hurdles in the MMC framework
and contain it better.

If it also works I'm happy for Ulf to merge all of this!

Yours,
Linus Walleij