Re: [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup

From: Rajendra Nayak
Date: Tue Dec 10 2019 - 23:38:16 EST




On 12/11/2019 6:05 AM, Douglas Anderson wrote:
Make i2c7 symmetric with the other i2c busses and comment that we have
no internal pull because there is an external one.

Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1")
Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
---

Reviewed-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>


arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 5eab3a282eba..05d30a56eca9 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -311,6 +311,8 @@ &qup_i2c7_default {
pinconf {
pins = "gpio6", "gpio7";
drive-strength = <2>;
+
+ /* Has external pullup */
bias-disable;
};
};


--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation