Re: [PATCH RESEND 3/4] dt-bindings: drm/bridge: analogix-anx78xx: support bypass GPIO

From: Hsin-Yi Wang
Date: Wed Dec 11 2019 - 01:34:32 EST


On Mon, Dec 9, 2019 at 11:32 PM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
Hi Laurent,
> You may have used a proportional font when writing this, the | doesn't
> align with anything using a fixed font. Do I assume correctly that the
> hardware multiplexer is actually a demultiplexer with one input and two
> outputs ?
> +-----------+
> +---------+ +------+ /--> | HDMI |
> | MT8173 | HDMI | -->| --/ | Connector |
> | HDMI | ------> |--/ | +-----------+
> | Encoder | | ->| --\ +-----------+ +-----------+
> +---------+ +------+ \--> | ANX7688 | ---> | USB-C |
> | Bridge | | Connector |
> +-----------+ +-----------+
>
Sorry for not noticing the font issue, this graph is correct.

> > There's a hardware mux that takes mt8173 hdmi as input and has 2
> > output port: native hdmi and anx7688 bridge.
> > If gpio is active, we would like it to go to HDMI.
> >
> > Previous approach is to make hardware mux a generic gpio mux bridge,
> > but this is probably a very rare use case that is only for
> > mt8173.(https://lore.kernel.org/lkml/57723AD2.8020806@xxxxxxxxxxxxxx/)
> > We merge the mux and anx7688 to a single bridge and leave this as an
> > optional feature in this time.
>
> I think that's a better approach, at least at the DT level. The HDMI
> demultiplexer should be represented as a DT node with 3 ports (one input
> and two outputs) with a control GPIO.
>
I've resend the original gpio mux driver. So for anx7688 there's 1
input and 1 output.

Thanks