Re: [alsa-devel] [PATCH v4 05/11] soundwire: intel: update interfaces between ASoC and SoundWire

[Pierre-Louis Bossart]

On 12/11/19 5:42 AM, Vinod Koul wrote:
> On 09-12-19, 17:55, Pierre-Louis Bossart wrote:
>
> > @@ -138,8 +126,6 @@ static struct sdw_intel_ctx
> >   		pdevinfo.name = "int-sdw";
> >   		pdevinfo.id = i;
> >   		pdevinfo.fwnode = acpi_fwnode_handle(adev);
> > -		pdevinfo.data = &link->res;
> > -		pdevinfo.size_data = sizeof(link->res);
> >   
> >   		pdev = platform_device_register_full(&pdevinfo);
> >   		if (IS_ERR(pdev)) {
> > @@ -224,10 +210,8 @@ EXPORT_SYMBOL(sdw_intel_init);
>
> This is still exported
>
> >   struct sdw_intel_res {
> > +	int count;
> >   	void __iomem *mmio_base;
> >   	int irq;
> >   	acpi_handle handle;
> >   	struct device *parent;
> >   	const struct sdw_intel_ops *ops;
> > -	void *arg;
> > +	struct device *dev;
> > +	u32 link_mask;
> >   };
> >   
> > -void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res);
>
> But prototype removed, so i think this is a miss in the series, can you
> fix that up

This is updated in a later patch that implements the new interfaces

-EXPORT_SYMBOL(sdw_intel_init);
+EXPORT_SYMBOL(sdw_intel_acpi_scan);

I will fix this but since there is no user for that function there will 
be no impact.