Re: [PATCH v5 0/6] Fix nits in the kunit

From: Brendan Higgins
Date: Wed Dec 11 2019 - 12:45:21 EST


On Wed, Dec 11, 2019 at 9:40 AM SeongJae Park <sj38.park@xxxxxxxxx> wrote:
>
> On Wed, Dec 11, 2019 at 6:22 PM shuah <shuah@xxxxxxxxxx> wrote:
> >
> > On 12/11/19 9:33 AM, SeongJae Park wrote:
> > > May I ask some comments?
> > >
> > >
> > > Thanks,
> > > SeongJae Park
> > >
> >
> > + Brendan
> >
> > > On Thu, 5 Dec 2019 10:34:34 +0100 SeongJae Park <sjpark@xxxxxxxxxx> wrote:
> > >
> > >>
> > >> This patchset contains trivial fixes for the kunit documentations and
> > >> the wrapper python scripts.
> > >>
> > >> This patchset is based on 'kselftest/test' branch of linux-kselftest[1]
> > >> and depends on Heidi's patch[2]. A complete tree is available at my repo:
> > >> https://github.com/sjp38/linux/tree/kunit_fix/20191205_v5
> > >>
> > >> Changes from v4
> > >> (https://lore.kernel.org/linux-doc/1575490683-13015-1-git-send-email-sj38.park@xxxxxxxxx/):
> > >> - Rebased on Heidi Fahim's patch[2]
> > >> - Fix failing kunit_tool_test test
> > >> - Add 'build_dir' option test in 'kunit_tool_test.py'
> > >>
> >
> > Please include Brendana Higgins on kunit patches.
>
> Not sure how I could forgot adding him. I will never forget from next time.

No worries. I still got the email from the list :-)

I think I reviewed all the patches in this series; I just need to test
them. I will try to have that done later today or tomorrow.

Cheers!