Re: [PATCH] soc: mediatek: cmdq: delete not used define

From: Bibby Hsieh
Date: Wed Dec 11 2019 - 20:36:35 EST


On Wed, 2019-12-11 at 19:59 +0100, matthias.bgg@xxxxxxxxxx wrote:
> From: Matthias Brugger <mbrugger@xxxxxxxx>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>
> Signed-off-by: Matthias Brugger <mbrugger@xxxxxxxx>

Thanks. :D

Reviewed-by: Bibby Hsieh <bibby.hsieh@xxxxxxxxxxxx>

>
> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {