Re: [PATCH 0/6] rtlwifi: convert rtl8192{ce,cu,de} to use generic functions

[Michael Straube]

On 2019-12-12 02:47, Pkshih wrote:
> On Wed, 2019-12-11 at 16:47 +0100, Michael Straube wrote:
> > This series converts the drivers rtl8192{ce,cu,de} to use the generic
> > functions rtl_query_rxpwrpercentage and rtl_signal_scale_mapping.
> >
> > Michael Straube (6):
> >  Â rtlwifi: rtl8192ce: use generic rtl_query_rxpwrpercentage
> >  Â rtlwifi: rtl8192cu: use generic rtl_query_rxpwrpercentage
> >  Â rtlwifi: rtl8192de: use generic rtl_query_rxpwrpercentage
> >  Â rtlwifi: rtl8192ce: use generic rtl_signal_scale_mapping
> >  Â rtlwifi: rtl8192cu: use generic rtl_signal_scale_mapping
> >  Â rtlwifi: rtl8192de: use generic rtl_signal_scale_mapping
> >
> >  Â.../wireless/realtek/rtlwifi/rtl8192ce/trx.cÂÂ| 48 ++----------------
> >  Â.../wireless/realtek/rtlwifi/rtl8192cu/mac.cÂÂ| 49 ++-----------------
> >  Â.../wireless/realtek/rtlwifi/rtl8192de/trx.cÂÂ| 47 ++----------------
> >  Â3 files changed, 14 insertions(+), 130 deletions(-)
>
> For all patches:
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

Thanks.

> Curiously. How can you find these function are identical?
While sending cleanup patches for some staging wifi drivers I noticed
that these functions are used in many of the realtek drivers and all
looked very similar. Then used grep and diff to verify.

Michael