Re: [PATCH] net: gemini: Fix memory leak in gmac_setup_txqs

From: Linus Walleij
Date: Mon Dec 16 2019 - 05:20:46 EST


On Sun, Dec 15, 2019 at 2:11 AM Navid Emamdoost
<navid.emamdoost@xxxxxxxxx> wrote:

> In the implementation of gmac_setup_txqs() the allocated desc_ring is
> leaked if TX queue base is not aligned. Release it via
> dma_free_coherent.
>
> Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>

Looks correct to me,
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij