Re: [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators

[Mark Brown]

On Wed, Dec 11, 2019 at 11:46:11AM +0200, Matti Vaittinen wrote:

> +static int bd71828_ldo6_get_voltage(struct regulator_dev *rdev)
> +{
> +	return BD71828_LDO_6_VOLTAGE;
> +}
> +
> +static const struct regulator_ops bd71828_ldo6_ops = {
> +	.enable = regulator_enable_regmap,
> +	.disable = regulator_disable_regmap,
> +	.get_voltage = bd71828_ldo6_get_voltage,

You can just set fixed_uV in the regulator_desc, you don't need a
get_voltage() operation here.  Otherwise this looks good, I'll apply it
and please send an incremental fix for this.

Attachment: signature.asc
Description: PGP signature