Re: [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode

[Dan Murphy]

Guido

On 12/17/19 9:40 AM, Guido GÃnther wrote:
> Hi Dan,
> On Tue, Dec 17, 2019 at 06:53:45AM -0600, Dan Murphy wrote:
> > Guido
> >
> > On 12/16/19 6:28 AM, Guido GÃnther wrote:
> > > Overvoltage protection and brightness mode are currently hardcoded
> > > as disabled in the driver. Make these configurable via DT.
> > Can we split these up to two separate patch series?
> Sure, should the binding doc updates be split as well?

Yes.

<snip>
> > extra debug statement
> They're not extra but meant to ease debugging the driver long therm but
> i can drop these if that's not wanted. The rest makes a lot of sense.
> Thanks a lot for having a look so promptly!

Yes please remove those we don't need extra noise in the log.

If someone wants to debug this then they can add the statements themselves

Dan