Re: [PATCH] clk: qcom: Make gcc_gpu_cfg_ahb_clk critical

From: Stephen Boyd
Date: Thu Dec 19 2019 - 01:00:22 EST


Quoting Jeffrey Hugo (2019-12-17 09:12:05)
> diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
> index df1d7056436c..26cc1458ce4a 100644
> --- a/drivers/clk/qcom/gcc-msm8998.c
> +++ b/drivers/clk/qcom/gcc-msm8998.c
> @@ -2044,6 +2044,7 @@ static struct clk_branch gcc_gpu_cfg_ahb_clk = {
> .hw.init = &(struct clk_init_data){
> .name = "gcc_gpu_cfg_ahb_clk",
> .ops = &clk_branch2_ops,
> + .flags = CLK_IS_CRITICAL, /* to access gpucc */

Can we not do the thing that Bjorn did to turn on ahb clks with runtime
PM for clk controllers that need them? See 892df0191b29 ("clk: qcom: Add
QCS404 TuringCC").