Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation

From: Michal Suchánek
Date: Thu Dec 19 2019 - 09:34:28 EST


On Tue, Dec 17, 2019 at 05:28:28PM -0500, Martin K. Petersen wrote:
>
> Michal,
>
> > + {"VMware", "VMware", NULL, BLIST_NO_MATCH_VENDOR | BLIST_NO_TRAY},
>
> Please don't introduce a blist flag to work around deficiencies in the
> matching interface. I suggest you tweak the matching functions so they
> handle a NULL vendor string correctly.

I don't think that will work with the interface for dynamically adding
entries through sysfs.

Thanks

Michal