Re: [v3 PATCH] fscrypt: Allow modular crypto algorithms

From: Eric Biggers
Date: Tue Dec 24 2019 - 17:39:15 EST


On Mon, Dec 23, 2019 at 03:46:23PM +0800, Herbert Xu wrote:
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index ef42ab040905..930793456d3a 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -10,6 +10,7 @@ config EXT3_FS
> select CRC16
> select CRYPTO
> select CRYPTO_CRC32C
> + select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
> help
> This config option is here only for backward compatibility. ext3
> filesystem is now handled by the ext4 driver.

This needs to be under EXT4_FS, not EXT3_FS. That should address the kbuild
test robot error.

(The fact that EXT3_FS selects options other than just EXT4_FS is unnecessary
and misleading; I'll send a separate patch to clean that up.)

- Eric